Quantcast

[GitHub] maven-indexer pull request #13: MINDEXER-97: Index/Store Extra OSGI Headers

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-indexer pull request #13: MINDEXER-97: Index/Store Extra OSGI Headers

asfgit
GitHub user sesuncedu opened a pull request:

    https://github.com/apache/maven-indexer/pull/13

    MINDEXER-97:  Index/Store Extra OSGI Headers

    * Add "Provide-Capability", "Require-Capability", and "Fragment-Host" to the set of indexed+stored manifest headers.
    * Calculate, index, and store SHA-256 checksum for bundle artifacts (required by the osgi repository service).
    * Add tests for new fields to OsgiArtifactIndexCreatorTest
    * Add new fields to index-reader library.
    * Bump serialization version UID
   
    This PR does not index/store the  DynamicImport-Package header, as this header is not used during resolution.
   
    Note that calculation of the SHA-256 checksum requires performing a sequential read of the entire artifact.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sesuncedu/maven-indexer MINDEXER-97

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-indexer/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
   
----
commit 579b413ef0d3ad396421b8e30606135e65ea9f8d
Author: Simon Spero <[hidden email]>
Date:   2017-03-19T00:06:29Z

    MINDEXER-97.
   
    Add "Provide-Capability", "Require-Capability", and "Fragment-Host" to the set of indexed+stored manifest headers.
   
    Calculate, index, and store SHA-256 checksum for bundle artifacts (required by the osgi repository service).
   
    Add tests for new fields to OsgiArtifactIndexCreatorTest
   
    Add new fields to index-reader library.

commit 3bb34360f9c62f0567777d4c50aca9f48d053dd4
Author: Simon Spero <[hidden email]>
Date:   2017-03-19T00:10:54Z

    Bump serialization version UID

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-indexer issue #13: MINDEXER-97: Index/Store Extra OSGI Headers

asfgit
Github user balazs-zsoldos commented on the issue:

    https://github.com/apache/maven-indexer/pull/13
 
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-indexer issue #13: MINDEXER-97: Index/Store Extra OSGI Headers

asfgit
In reply to this post by asfgit
Github user carlspring commented on the issue:

    https://github.com/apache/maven-indexer/pull/13
 
   
   
    Hi,
   
    Shouldn't this be applied to the `master` branch and be included in `6.0` instead?
   
    @cstamas : What do you think?
   
    Cheers,
   
    Martin
   
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-indexer issue #13: MINDEXER-97: Index/Store Extra OSGI Headers

asfgit
In reply to this post by asfgit
Github user sesuncedu commented on the issue:

    https://github.com/apache/maven-indexer/pull/13
 
    I have been consistently confused about which branch is live, so it would not surprise me either way ☺️.
    I had been working against main on some code to use the central index to build a database for use as an OSGI resolver. I noted the missing fields... after I'd done a whole bunch of defactoring to decouple index reading from the rest of the code.... D'oh!
   
    I can cross port these changes to master (well, not the index reader ones) :) My main goal is to get the extra fields into the index on central. I'd presume that 5.1.2 would be the smaller jump.
   
    Would it be possible to make a 5.1.2 release? And would it be possible to have  run it running on central in the near future?
   
     My primary concern if I were the admin would be the need to perform the sequential read of the entire bundle jar to generate the sha-256 checksum. It ought not be too significant a burden compared to the overall level of activity, but depending on what else is going on on the storage side, it might be annoying.
   
    I haven't checked  to see how full  reindexing is handled, and if a previously calculated SHA-256 could be fetched for less than the cost of the sequential read (lucene + cache + storage load / architecture = magic). Alternative would be to save SHA-256 hashes in a simple k/v store.
   
     (now that full sha-1 has been broken, it is probably time to switch over to SHA-256, but that's a much more pervasive change).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-indexer issue #13: MINDEXER-97: Index/Store Extra OSGI Headers

asfgit
In reply to this post by asfgit
Github user sesuncedu commented on the issue:

    https://github.com/apache/maven-indexer/pull/13
 
    Also, OSGI headers really need a custom analyzer, as they have their own nested organization and datatyping. It doesn't seem worth it for this change, but would be worth it for the next major if that were going to lucene 6 (version number comparison + range searches could possibly be handled with a bit of trie-abuse. Qualifiers are the real headache, especially since maven and OSGI have different opinions about whether 5.0.0[.-]SNAPSHOT is in the range [4.3.0,5).   )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-indexer issue #13: MINDEXER-97: Index/Store Extra OSGI Headers

asfgit
In reply to this post by asfgit
Github user sesuncedu commented on the issue:

    https://github.com/apache/maven-indexer/pull/13
 
    Also, if I do forward port, should I also try and forward port index-reader?
   
    And, if you are thinking of releasing 5.1.2, would you like me to do a more detailed  job of bundle making (e.g. extracting a pure api into a separate package, making the implementation private, adding per-package version numbers, and adding an activator to bind the implementation as a service).
   
    I'd also attach the bundle baseline task to the verify stage, even though it can't really do much till there's been a previous release to compare against.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-indexer issue #13: MINDEXER-97: Index/Store Extra OSGI Headers

asfgit
In reply to this post by asfgit
Github user sesuncedu commented on the issue:

    https://github.com/apache/maven-indexer/pull/13
 
    I have changed the package version for the indexer to 5.2.0 because there are minor changes from prior 5.1.2.SNAPSHOT versions. The overall 5.x release version might want to skip to 5.1.3 since 5.1.2-SNAPSHOT has been around for so long.  I am tempted to set the bundle version for index-reader to 5.2.0, to avoid possible confusion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...