[GitHub] [maven-fluido-skin] slawekjaranowski opened a new pull request #15: [MSKINS-161] Upgrade Facebook like button integration

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-fluido-skin] slawekjaranowski opened a new pull request #15: [MSKINS-161] Upgrade Facebook like button integration

GitBox
slawekjaranowski opened a new pull request #15: [MSKINS-161] Upgrade Facebook like button integration
URL: https://github.com/apache/maven-fluido-skin/pull/15
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-fluido-skin] michael-o commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration

GitBox
michael-o commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration
URL: https://github.com/apache/maven-fluido-skin/pull/15#discussion_r397451792
 
 

 ##########
 File path: src/main/resources/META-INF/maven/site-macros.vm
 ##########
 @@ -678,11 +682,11 @@ $indent     </ul>##
 #*  *##if ( $sideBarEnabled )
 #*    *##set( $dataSize = "medium" )
 #*    *##set( $dataAlign = "left" )
-    <div id="twitter">
+    <div id="twitter" style="border:none; margin-top: 10px">
 #*  *##else
 #*    *##set( $dataSize = "large" )
 #*    *##set( $dataAlign = "right" )
-    <ul class="nav pull-right"><li>
+    <ul class="nav pull-right" style="border:none; margin-top: 7px"><li>
 
 Review comment:
   Why did you modify these?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-fluido-skin] slawekjaranowski commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration

GitBox
In reply to this post by GitBox
slawekjaranowski commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration
URL: https://github.com/apache/maven-fluido-skin/pull/15#discussion_r397476454
 
 

 ##########
 File path: src/main/resources/META-INF/maven/site-macros.vm
 ##########
 @@ -678,11 +682,11 @@ $indent     </ul>##
 #*  *##if ( $sideBarEnabled )
 #*    *##set( $dataSize = "medium" )
 #*    *##set( $dataAlign = "left" )
-    <div id="twitter">
+    <div id="twitter" style="border:none; margin-top: 10px">
 #*  *##else
 #*    *##set( $dataSize = "large" )
 #*    *##set( $dataAlign = "right" )
-    <ul class="nav pull-right"><li>
+    <ul class="nav pull-right" style="border:none; margin-top: 7px"><li>
 
 Review comment:
   Because Twitter button was start from top without margin.
   Google search and facebook has some margin from top.
   It didn't look good.
   You can see original. eg: https://maven.apache.org/skins/maven-fluido-skin/mskins-24_topbar/index.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-fluido-skin] slawekjaranowski commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration

GitBox
In reply to this post by GitBox
slawekjaranowski commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration
URL: https://github.com/apache/maven-fluido-skin/pull/15#discussion_r398042539
 
 

 ##########
 File path: src/main/resources/META-INF/maven/site-macros.vm
 ##########
 @@ -678,11 +682,11 @@ $indent     </ul>##
 #*  *##if ( $sideBarEnabled )
 #*    *##set( $dataSize = "medium" )
 #*    *##set( $dataAlign = "left" )
-    <div id="twitter">
+    <div id="twitter" style="border:none; margin-top: 10px">
 #*  *##else
 #*    *##set( $dataSize = "large" )
 #*    *##set( $dataAlign = "right" )
-    <ul class="nav pull-right"><li>
+    <ul class="nav pull-right" style="border:none; margin-top: 7px"><li>
 
 Review comment:
   before:
   ![image](https://user-images.githubusercontent.com/3578921/77567288-3bdb5a80-6ec7-11ea-9e9f-f6289178325d.png)
   
   after:
   ![image](https://user-images.githubusercontent.com/3578921/77567351-50b7ee00-6ec7-11ea-9bd3-f6f6348841cf.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-fluido-skin] asfgit closed pull request #15: [MSKINS-161] Upgrade Facebook like button integration

GitBox
In reply to this post by GitBox
asfgit closed pull request #15: [MSKINS-161] Upgrade Facebook like button integration
URL: https://github.com/apache/maven-fluido-skin/pull/15
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services