[GitHub] [maven-enforcer] TimSijstermans opened a new pull request #76: [MENFORCER-194] Added IT to verify RequireSameVersion rule considers transitive dependencies

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-enforcer] TimSijstermans opened a new pull request #76: [MENFORCER-194] Added IT to verify RequireSameVersion rule considers transitive dependencies

GitBox

TimSijstermans opened a new pull request #76:
URL: https://github.com/apache/maven-enforcer/pull/76


   The issue is about the RequireSameVersion rule; it claimed transitive dependencies were not considered.
   Added ITs to verify this is no longer an issues
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue.  Your pull request should address just this issue, without
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-enforcer] rfscholte closed pull request #76: [MENFORCER-194] Added IT to verify RequireSameVersion rule considers transitive dependencies

GitBox

rfscholte closed pull request #76:
URL: https://github.com/apache/maven-enforcer/pull/76


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-enforcer] rfscholte commented on pull request #76: [MENFORCER-194] Added IT to verify RequireSameVersion rule considers transitive dependencies

GitBox
In reply to this post by GitBox

rfscholte commented on pull request #76:
URL: https://github.com/apache/maven-enforcer/pull/76#issuecomment-667520281


   Merged with https://github.com/apache/maven-enforcer/commit/4ff8bf4de1893b3de8166c48c57ae5363ba11eda
   Thanks for the PR!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]