[GitHub] [maven-enforcer] KroArtem opened a new pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

GitBox

KroArtem commented on pull request #86:
URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-784309551


   @hboutemy , I see that you're also requested for a review, do you have any review comments?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

GitBox
In reply to this post by GitBox

KroArtem commented on pull request #86:
URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-784860238


   Based on a discussion in JIRA ticket, this PR should be reworked to support either excludes or includes, not both at the same time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


12