[GitHub] [maven-doxia] minfrin opened a new pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-doxia] minfrin opened a new pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag

GitBox
minfrin opened a new pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19
 
 
   This will allow maven generated documentation to include a demo of the keygen tag, as with other form elements.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-doxia] michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag

GitBox
michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593087315
 
 
   Mozilla says this is obsolete: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/keygen

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-doxia] minfrin commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag

GitBox
In reply to this post by GitBox
minfrin commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593088806
 
 
   The tag is a formal part of the html5 spec as follows: https://www.w3.org/TR/2014/REC-html5-20141028/single-page.html#the-keygen-element
   
   The need to both document and provide examples of the tag in use is in an attempt to bring the tag up to date with respect to current crypto standards. Not being able to include the  tag in doxia generated documentation is making our lives hard.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-doxia] elharo commented on a change in pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag

GitBox
In reply to this post by GitBox
elharo commented on a change in pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#discussion_r386104912
 
 

 ##########
 File path: doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
 ##########
 @@ -473,6 +473,17 @@ public String toString()
     /** Xhtml tag for <code>kbd</code>. */
     Tag KBD = Tag.KBD;
 
+    /** Html5 tag for <code>keygen</code>. */
 
 Review comment:
   Html5 --> HTML 5

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-doxia] michael-o commented on a change in pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag

GitBox
In reply to this post by GitBox
michael-o commented on a change in pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#discussion_r386105109
 
 

 ##########
 File path: doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
 ##########
 @@ -473,6 +473,17 @@ public String toString()
     /** Xhtml tag for <code>kbd</code>. */
     Tag KBD = Tag.KBD;
 
+    /** Html5 tag for <code>keygen</code>. */
 
 Review comment:
   It is actually HTML5. See https://html.spec.whatwg.org/multipage/introduction.html#is-this-html5?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-doxia] michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag

GitBox
In reply to this post by GitBox
michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593093142
 
 
   Surprinsingly, the most recent version does not mention a deprecation: https://html.spec.whatwg.org/#keygen

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-doxia] michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag

GitBox
In reply to this post by GitBox
michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593093527
 
 
   Branch pushed, awaiting tests...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-doxia] asfgit closed pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag

GitBox
In reply to this post by GitBox
asfgit closed pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]