[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

GitBox
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993381
 
 

 ##########
 File path: doxia-core/src/main/java/org/apache/maven/doxia/util/XmlValidator.java
 ##########
 @@ -161,13 +164,12 @@ private Log getLog()
         private static final Pattern ELEMENT_TYPE_PATTERN =
             Pattern.compile( "Element type \".*\" must be declared.", Pattern.DOTALL );
 
-        private final Log log;
+        private final Logger log = LoggerFactory.getLogger( MessagesErrorHandler.class );
 
 Review comment:
   static?
   logger?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]