[GitHub] [maven-compiler-plugin] qxo opened a new pull request #33: feat: add skippedKey for check if "Nothing to compile"

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-compiler-plugin] qxo opened a new pull request #33: feat: add skippedKey for check if "Nothing to compile"

GitBox

qxo opened a new pull request #33:
URL: https://github.com/apache/maven-compiler-plugin/pull/33


   ie:
   when "Nothing to compile" then skip then test1(process-classes)
   make the build faster
   ```
    <plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-compiler-plugin</artifactId>
    <executions>
    <execution>
    <id>default-compile</id>
    <phase>compile</phase>
    <goals>
    <goal>compile</goal>
    </goals>
    <configuration>
    <skippedKey>nothingToCompileOn</skippedKey>
    </configuration>
    </execution>
    </executions>
    </plugin>
    <plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-antrun-plugin</artifactId>
    <version>3.0.0</version>
    <executions>
     <execution>
    <id>test1</id>
    <phase>process-classes</phase>
    <configuration>
     <target>
    <echoproperties>
    <propertyset><propertyref prefix="nothing"/></propertyset>
    </echoproperties>
     </target>
     <skip>${nothingToCompileOn}</skip>
    </configuration>
    <goals>
     <goal>run</goal>
    </goals>
     </execution>
    </executions>
    </plugin>
   ```
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue.  Your pull request should address just this issue, without
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MPH-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MPH-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-compiler-plugin] qxo commented on pull request #33: feat: add skippedKey for check if "Nothing to compile"

GitBox

qxo commented on pull request #33:
URL: https://github.com/apache/maven-compiler-plugin/pull/33#issuecomment-625913074


   ref: https://issues.apache.org/jira/browse/MCOMPILER-416


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-compiler-plugin] rfscholte commented on pull request #33: feat: add skippedKey for check if "Nothing to compile"

GitBox
In reply to this post by GitBox

rfscholte commented on pull request #33:
URL: https://github.com/apache/maven-compiler-plugin/pull/33#issuecomment-625913422


   I'm missing a [ticket in Jira |http://issues.apache.org/jira/browse/MCOMPILER] and a good valid usecase to implement this, because this now looks like a hack.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-compiler-plugin] rfscholte commented on pull request #33: MCOMPILER-416 - add skippedKey for check if "Nothing to compile"

GitBox
In reply to this post by GitBox

rfscholte commented on pull request #33:
URL: https://github.com/apache/maven-compiler-plugin/pull/33#issuecomment-633026760


   Marked as `won't fix` in MCOMPILER-416


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-compiler-plugin] rfscholte closed pull request #33: MCOMPILER-416 - add skippedKey for check if "Nothing to compile"

GitBox
In reply to this post by GitBox

rfscholte closed pull request #33:
URL: https://github.com/apache/maven-compiler-plugin/pull/33


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-compiler-plugin] rfscholte edited a comment on pull request #33: MCOMPILER-416 - add skippedKey for check if "Nothing to compile"

GitBox
In reply to this post by GitBox

rfscholte edited a comment on pull request #33:
URL: https://github.com/apache/maven-compiler-plugin/pull/33#issuecomment-633026760


   Marked as `won't fix` in [MCOMPILER-416](https://issues.apache.org/jira/browse/MCOMPILER-416)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]