[GitHub] [maven] azaretsky opened a new pull request #296: [MNG-6790] - Redundant code in MavenCli.cliMerge

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] azaretsky opened a new pull request #296: [MNG-6790] - Redundant code in MavenCli.cliMerge

GitBox
azaretsky opened a new pull request #296: [MNG-6790] - Redundant code in MavenCli.cliMerge
URL: https://github.com/apache/maven/pull/296
 
 
   cliMerge has a code to append all unrecognized arguments (i.e. goals)
   from maven.config to the resulting CommandLine object. But this code
   always does nothing since the result of maven.config parsing is checked
   for absence of any such unrecognized arguments right before the merging
   is performed.
   
   A corresponding assert statement is added instead of this dead code, so
   that anyone looking at this method can immediately see that this
   arguments are not just being ignored, but are actually not present.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services