[GitHub] [maven-archiver] elharo opened a new pull request #12: unignore and fix test whose failure was incorrectly attributed to a JDK bug

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] elharo opened a new pull request #12: unignore and fix test whose failure was incorrectly attributed to a JDK bug

GitBox

elharo opened a new pull request #12:
URL: https://github.com/apache/maven-archiver/pull/12


   @michael-o


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] elharo commented on a change in pull request #12: unignore and fix test whose failure was incorrectly attributed to a JDK bug

GitBox

elharo commented on a change in pull request #12:
URL: https://github.com/apache/maven-archiver/pull/12#discussion_r524283416



##########
File path: src/test/java/org/apache/maven/archiver/MavenArchiverTest.java
##########
@@ -276,13 +273,8 @@ public void testRecreation()
         }
 
         archiver.createArchive( session, project, config );
-        // Is the assumption correct that the jar file itself
-        // should have the same last modified time as the files itself ?

Review comment:
       This assumption was not correct.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]