[GitHub] [maven-archiver] elharo opened a new pull request #10: [MSHARED-955] make parseOutputTimestamp static

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] elharo opened a new pull request #10: [MSHARED-955] make parseOutputTimestamp static

GitBox

elharo opened a new pull request #10:
URL: https://github.com/apache/maven-archiver/pull/10


   @hboutemy  @mabrarov


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] pzygielo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

GitBox

pzygielo commented on pull request #10:
URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-684976887


   > Isn't it sufficient to notify users of this library about this incompatible class change
   
   Maybe it is sufficient, but one has to be aware of that to prepare notification.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] elharo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

GitBox
In reply to this post by GitBox

elharo commented on pull request #10:
URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-684984178


   I think the issue only appears if a subclass overrides this method.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] elharo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

GitBox
In reply to this post by GitBox

elharo commented on pull request #10:
URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685019474


   @pzygielo can you provide more details on what code would be required to trigger this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] pzygielo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

GitBox
In reply to this post by GitBox

pzygielo commented on pull request #10:
URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685044143


   > @pzygielo can you provide more details on what code would be required to trigger this?
   
   See https://github.com/pzrep/MSHARED-955
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] pzygielo commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

GitBox
In reply to this post by GitBox

pzygielo commented on pull request #10:
URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685128506


   > That's not something I'm worried about happening in practice.
   
   I know. But I do.
   
   So I've updated my example for the case, where this dependency is overriden in assembly plugin (i.e. archiver is no longer direct dependency of code in my example, but is utilized by plugin).
   
   Per http://maven.apache.org/plugins/maven-assembly-plugin/dependencies.html assembly plugin uses archiver in version 3.5.0 (the latest).
   
   Per https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_dependencies_Tag:
   > You could configure the dependencies of the Build plugins, commonly to use a more recent dependency
   > version.
   
   So I do in my example, pretending that 3.5.1-SNAPSHOT is released now and I like other changes in it, and there is no better release of assembly plugin. Example shows that proposed change is not backward compatible.
   
   ---
   I'm only saying, that if there is no other way - it shall be reflected in version of plugin, as per https://semver.org/, which might not be observed here but is kind of standard:
   > increment MAJOR version when you make incompatible API changes,
   
   or **at least** as @mabrarov said - very clearly stated in RN.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] rfscholte commented on pull request #10: [MSHARED-955] make parseOutputTimestamp static

GitBox
In reply to this post by GitBox

rfscholte commented on pull request #10:
URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685436731


   For the record: Maven doesn't really understand semver, it is just a hint. If for the same groupId+artifactId a version 1.0 and 3.1 are in the dependency graph, Maven will pick only 1 based on the "nearest wins"-rule. Marking breaking changes with the versions might work for frameworks like spring, but not for libraries like commons-lang. Hence they made the right decision to change both artifactId and the package to prevent collisions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]