[GitHub] [maven-archiver] elharo commented on pull request #13: test was asserting more than Java promises

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-archiver] elharo commented on pull request #13: test was asserting more than Java promises

GitBox

elharo commented on pull request #13:
URL: https://github.com/apache/maven-archiver/pull/13#issuecomment-728255605


   I don't think it is. That was an incorrect diagnosis of the test failure. The modification data equality failures were not simply the result of truncating milliseconds; and if they had been, would have been fixed by JDK 10+, which they weren't.
   
   The real issue is that modification dates aren't always precisely reproducible to the millisecond and can change asynchornously. It looks like a simple setter/getter for an object property, but it isn't.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]