[GitHub] hboutemy commented on a change in pull request #11: Propagate macro related exceptions to caller in xhtml parser

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] hboutemy commented on a change in pull request #11: Propagate macro related exceptions to caller in xhtml parser

GitBox
hboutemy commented on a change in pull request #11: Propagate macro related exceptions to caller in xhtml parser
URL: https://github.com/apache/maven-doxia/pull/11#discussion_r249715464
 
 

 ##########
 File path: doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlParser.java
 ##########
 @@ -269,11 +269,11 @@ private void processMacro( String text, Sink sink )
         }
         catch ( MacroExecutionException e )
         {
-            throw new XmlPullParserException( "Unable to execute macro in the document: " + macroName );
+            throw new XmlPullParserException( "Unable to execute macro in the document: " + macroName , null, e );
 
 Review comment:
   can you provide an example of failing macro for me to test in real conditions how the failure renders without and with the update, please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]