[GitHub] hazendaz commented on a change in pull request #5: [DOXIA-534] Migrate logging to Sl4j

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] hazendaz commented on a change in pull request #5: [DOXIA-534] Migrate logging to Sl4j

GitBox
hazendaz commented on a change in pull request #5: [DOXIA-534] Migrate logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#discussion_r159147868
 
 

 ##########
 File path: doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java
 ##########
 @@ -1322,12 +1322,12 @@ private SinkEventAttributeSet getGraphicsAttributes( String logo )
         }
         catch ( IOException e )
         {
-            getLog().debug( e );
+            getLog().debug( e.getMessage() );
 
 Review comment:
   @slachiewicz @michael-o Proper code here would be ```getLog().debug("", e)```.  That assumes you want the full stack trace and not just the message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]