[GitHub] bhav0904 commented on issue #2: [JXR-100] Fix cross reference generation where there are spaces befor..

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] bhav0904 commented on issue #2: [JXR-100] Fix cross reference generation where there are spaces befor..

GitBox
bhav0904 commented on issue #2: [JXR-100] Fix cross reference generation where there are spaces befor..
URL: https://github.com/apache/maven-jxr/pull/2#issuecomment-347204846
 
 
   It?s not, it was an unused method that I found and wanted to clean up.
   
   On Mon, 27 Nov 2017 at 9:31 AM, Robert Scholte <[hidden email]>
   wrote:
   
   > *@rfscholte* commented on this pull request.
   > ------------------------------
   >
   > In maven-jxr/src/main/java/org/apache/maven/jxr/JavaCodeTransform.java
   > <https://github.com/apache/maven-jxr/pull/2#discussion_r153211196>:
   >
   > > @@ -676,25 +676,6 @@ public final String xrLine( String line, String packageName, ClassType classType
   >          return buff.toString();
   >      }
   >
   > -    /**
   > -     * Highlight the package in this line.
   > -     *
   > -     * @param line input line
   > -     * @param packageName package name
   > -     * @return input line with linked package
   > -     */
   > -    public final String xrLine( String line, String packageName )
   >
   > I don't think the removal of this method is part of the issue
   >
   > ?
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-jxr/pull/2#pullrequestreview-79184034>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/ABtG0QriTlpt_4ryEA-MXcgXrQUE_J0Mks5s6se2gaJpZM4QrBLp>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]