[GitHub] andretadeu commented on issue #4: [MJAR-254] Finish the fix of MJAR-198.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] andretadeu commented on issue #4: [MJAR-254] Finish the fix of MJAR-198.

GitBox
andretadeu commented on issue #4: [MJAR-254] Finish the fix of MJAR-198.
URL: https://github.com/apache/maven-jar-plugin/pull/4#issuecomment-453645158
 
 
   I mostly reused the changes that came with MJAR-198, which already used:
   
   ```{java}
           final File artifact = getProject().getArtifact().getFile();
           if ( artifact != null )
           {
               final String defaultArtifactName = artifact.getName().replace( ".jar", "" );
               return artifact.isFile() && defaultArtifactName.equals( finalName );
           }
           else
           {
               return false;
           }
   ```
   
   I can change it, but I'll end up removing the changes from MJAR-198 and redoing it in the way you suggested. If you have no objections, I'll redo this correction in this same PR, except if you prefer it in another PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services