[Commented] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Commented] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS

Piotr Zygielo (Jira)

    [ https://issues.apache.org/jira/browse/SUREFIRE-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148378#comment-17148378 ]

Peter Palaga commented on SUREFIRE-1809:
----------------------------------------

Sorry, apparently there was nobody before you to build this on Windows. Could you please try to build all modules skipping tests first with

{code}
mvn clean install -DskipTests -Denforce=false -Dquarkus.build.skip
{code}

and then run the problematic itest module

{code}
cd integration-tests/main
mvn clean test
{code}


> Differences between Oracle JDK and AdoptOpenJDK caused by JPMS
> --------------------------------------------------------------
>
>                 Key: SUREFIRE-1809
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1809
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin
>    Affects Versions: 3.0.0-M5
>            Reporter: Jiri Ondrusek
>            Assignee: Tibor Digana
>            Priority: Major
>             Fix For: 3.0.0-M6
>
>
> I was upgrading maven-surefire-plugin to 3.0.0-M5 in [camel-quarkus|[https://github.com/apache/camel-quarkus]] project. Unfortunately there was a test which was failing on CI (using AdoptOpenJDK build 11.0.7+10) and there was no failure on my local machine (using Oracle "11.0.7" 2020-04-14 LTS).
> Problem was caused by JPMS. On Orace JDK this was turned off by default. On AdoptOpenJDK it was turned on by default. Solution was to turn this feature off by configuration (https://github.com/apache/camel-quarkus/pull/1383).
> It would be nice if default behavior was the same for different Java vendors.
> Difference seems to be coming from this line - https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1423
> On AdoptOpenJDK both 3 clausules are true. On Oracle JDK the last one is false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)