[Commented] (SUREFIRE-1557) Test modular build on Java 10

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Commented] (SUREFIRE-1557) Test modular build on Java 10

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SUREFIRE-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615369#comment-16615369 ]

Tibor Digana commented on SUREFIRE-1557:
----------------------------------------

[~sor]
[~jactor]
Hey guys, I just wanted to ping you. Do you want to include the fix in the nearest version 2.22.1?

> Test modular build on Java 10
> -----------------------------
>
>                 Key: SUREFIRE-1557
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1557
>             Project: Maven Surefire
>          Issue Type: Improvement
>    Affects Versions: 2.22.0
>            Reporter: Tor Egil Jacobsen
>            Assignee: Christian Stein
>            Priority: Major
>
> A modular build on GitHub, [jactor-rises|https://github.com/jactor-rises/jactor-rises/tree/feature/junit.jupiter_configuration], fails when running with surefire 2.22.0
> All tests run perfectly fine in my IntelliJ idea. When building with maven, all surefire reports fails with an {{InaccessableObjectException}} with message similar to this one: {{java.lang.reflect.InaccessibleObjectException: Unable to make com.github.jactor.rises.commons.dto.UserDtoTest() accessible: module jactor.rises.commons does not "opens com.github.jactor.rises.commons.dto" to unnamed module @3fc2959f}}
> If one deletes all {{module-info.java}} files, the build succeeds. I thought that during unit testing, the module should be opened by the surefire plugin. It beats the purpose of having modular jar-files if we need to open the module in order to test it...
> Based on the issue created for the junit-team: [junit5-jupiter-starter-maven out of date?|https://github.com/junit-team/junit5-samples/issues/81]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)