[Commented] (MSHARED-837) add an API to configure Reproducible Builds with outputTimestamp

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Commented] (MSHARED-837) add an API to configure Reproducible Builds with outputTimestamp

Michael Osipov (Jira)

    [ https://issues.apache.org/jira/browse/MSHARED-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948501#comment-16948501 ]

Herve Boutemy commented on MSHARED-837:
---------------------------------------

{quote}You obviously don't understand the difference between {{X}}, {{XX}}, {{XXX}}.
{{X}} parses: 08, 0800, 08:00
{{XX}} parses: 08, 0800
{{XXX}} parses: 08:00{quote}
Thank you: now I understand at least the first part (could not find that info in the SimpleDateFormat javadoc)

{quote}Since the datetime is in extended format, the tz offset has to be too. Therefore, it can only be {{XXX}}.{quote}
sorry, I don't understand this sentence

{quote}Even if you don't care, I *do* and you did ask for review. We are designing new things where we can use well-established formats/standards. I don't see reason to deviate from.{quote}
+1
but I need to understand how {{X}} is not a well-established format

{quote}Just pick the first, modify the tests and you are done.{quote}
modifying the test while providing the update on code would have avoided us a few days of discussion: isn't it a well established convention?

> add an API to configure Reproducible Builds with outputTimestamp
> ----------------------------------------------------------------
>
>                 Key: MSHARED-837
>                 URL: https://issues.apache.org/jira/browse/MSHARED-837
>             Project: Maven Shared Components
>          Issue Type: New Feature
>          Components: maven-archiver
>    Affects Versions: maven-archiver-3.4.0
>            Reporter: Herve Boutemy
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: maven-archiver-3.4.1
>
>
> creating an archive in a Reproducible Builds way requires to configure archiver with an output timestamp: see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74682318
> The timestamp value can't be natively injected as Date with Plexus, because Plexus Date injection uses local timezone, then is not reproducible: see https://codehaus-plexus.github.io/plexus-containers/plexus-container-default/xref/org/codehaus/plexus/component/configurator/converters/basic/DateConverter.html
> Then we need top inject ${project.build.outputTimestamp} as a String and provide an API to parse this String to a Date, before calling plexus-archiver's configureReproducible https://github.com/codehaus-plexus/plexus-archiver/pull/121



--
This message was sent by Atlassian Jira
(v8.3.4#803005)