[Commented] (MSHADE-285) It should be possible to shade test sources as a JAR

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Commented] (MSHADE-285) It should be possible to shade test sources as a JAR

Christian Schlichtherle (Jira)

    [ https://issues.apache.org/jira/browse/MSHADE-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970852#comment-16970852 ]

Peter De Maeyer commented on MSHADE-285:
----------------------------------------

Fixed + integration test added, pull request created.
I took the second approach: introduced an optional parameter {{createTestSourcesJar}} with similar behavior as {{createSourcesJar}}, but for test sources.

> It should be possible to shade test sources as a JAR
> ----------------------------------------------------
>
>                 Key: MSHADE-285
>                 URL: https://issues.apache.org/jira/browse/MSHADE-285
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Peter De Maeyer
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The configuration option {{createSourcesJar}} allows to shade sources JAR, but there is no such option for test sources.
> I see two solutions:
>  # Extend the semantics of {{createSourcesJar}} such that, when combined with {{shadeTestJar}}, is also creates the _test_ sources JAR.
>  # Introduce a new configuration option {{createTestSourcesJar}}, similar to {{createSourcesJar}}.
> The former is very intuitive, but it lacks the flexibility to create a JAR, sources JAR, test JAR, but _no_ test sources JAR. The latter allows more flexibility.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)