[Commented] (MRRESOURCES-94) Performance issue in ProcessRemoteResourcesMojo.configureVelocityContext(...)

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[Commented] (MRRESOURCES-94) Performance issue in ProcessRemoteResourcesMojo.configureVelocityContext(...)

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/MRRESOURCES-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089766#comment-16089766 ]

ASF GitHub Bot commented on MRRESOURCES-94:

GitHub user famod opened a pull request:


    MRRESOURCES-94 Lazily provide projects* velocity properties

    Alternative approach to #123 as [suggested](https://github.com/apache/maven-plugins/pull/123#issuecomment-315438386) by @rfscholte.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/famod/maven-plugins MRRESOURCES-94-lazy-projects

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
commit b3fb23aa18b90e67920009f5f312166b8db12a50
Author: Falko Modler <[hidden email]>
Date:   2017-07-17T12:39:52Z

    MRRESOURCES-94 Lazily provide projects* velocity properties


> Performance issue in ProcessRemoteResourcesMojo.configureVelocityContext(...)
> -----------------------------------------------------------------------------
>                 Key: MRRESOURCES-94
>                 URL: https://issues.apache.org/jira/browse/MRRESOURCES-94
>             Project: Maven Remote Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 1.5
>            Reporter: Falko Modler
> I was wondering why our multi-threaded maven build of 80+ modules took so long even when excluding tests. I checked every plugin execution and to my surprise, {{maven-remote-resources-plugin}} was the number 1 consumer *before* compiler-plugin etc.
> We use {{maven-remote-resources-plugin}} just to exchange some few xml files among the modules, nothing spectacular!
> While debugging the plugin I found out that {{ProcessRemoteResourcesMojo.configureVelocityContext(VelocityContext context)}} may take *up to 30 seconds* for our project setup which is not acceptable.
> Almost certainly the problem is caused by the following project lookups (especially {{getProjects()}}):
> {noformat}
>         List<MavenProject> projects = getProjects();
>         context.put( "projects", projects );
>         context.put( "projectsSortedByOrganization", getProjectsSortedByOrganization( projects ) );
> {noformat}
> As we do not use velocity templates at all, the solution for us was to patch the plugin to call {{configureVelocityContext(...)}} only on demand, not eagerly. Of course this won't help when using velocity templates...

This message was sent by Atlassian JIRA