[Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

Marco Patavini (Jira)

    [ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243028#comment-17243028 ]

Michael Osipov commented on MRELEASE-899:
-----------------------------------------

What do you mean by "it"?

> release:prepare should not change the line separator but detect effective line separator from pom.xml
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-899
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-899
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>            Reporter: Ralph van Etten
>            Priority: Major
>
> Currently the plugin use the system property {{line.separator}} when it rewrites the pom.xml.
> This causes trouble, because every line in changed, when a project is released sometimes under Windows and sometimes under Linux (because of its different line separators). (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the systems line separator but the line separator that is already used in the pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm someone else.
> Therefore it would be an great feature when there would be an property that define the expected behaviour, maybe in the same way it is done by the maven-assembly-plugin's property fileSet.lineEnding (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)