[Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Commented] (MNG-6256) Maven script can break if "-f" path contains special characters

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/MNG-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088575#comment-16088575 ]

ASF GitHub Bot commented on MNG-6256:
-------------------------------------

Github user etzelc commented on the issue:

    https://github.com/apache/maven/pull/128
 
    I will have a closer look next week, right now only tested with Windows (since only cmd script was modified). In the {{mvn}} script the string of the {{echo}} is already completely in double quotes, but I will have a look.
   
    I have already an IT with three tests (for space, bracket and ampersand), but found out that maven has problems with ampersands in folder names. Probably I will remove that special case. See https://github.com/etzelc/maven-integration-testing/tree/MNG-6256



> Maven script can break if "-f" path contains special characters
> ----------------------------------------------------------------
>
>                 Key: MNG-6256
>                 URL: https://issues.apache.org/jira/browse/MNG-6256
>             Project: Maven
>          Issue Type: Bug
>          Components: Command Line
>    Affects Versions: 3.5.0
>         Environment: Windows 10 with PowerShell
>            Reporter: Christoph Etzel
>
> Executing maven on Windows using the {{\-f}} or {{--file}} parameter to specify an alternate POM file can break the script if the path contains special characters.
> It was originally discovered on a Windows Jenkins instance with working directory located under C:\Program Files (x86)\Jenkins......
> Example:
> {code:java}mvn -f "folderWithClosing)Bracket/pomFolder"{code}
> Command line output: {{"Bracket/pomFolder" kann syntaktisch an dieser Stelle nicht verarbeitet werden.}}
> Just for fun: Starting calc from maven script using {{\-f}}
> {code:java}mvn -f " ' & start calc"{code}
> Command line output: {{POM file  '}} and a new calculator process
> The bug was introduced with commit https://github.com/apache/maven/commit/f8ab2a650f32d5d87126d341d9bbfccbf99fd0ca for issue MNG-5889.
> Workaround: Use maven 3.3.9 or below
> Possible fix: Escape {{%FILE_ARG%}} and {{%POM_DIR%}} with {{"}} in {{echo}} commands in {{maven.cmd}} (line 120 and 129).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...