[Commented] (MENFORCER-376) Add support for excludes/includes in requireJavaVendor rule

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Commented] (MENFORCER-376) Add support for excludes/includes in requireJavaVendor rule

Andres Almiray (Jira)

    [ https://issues.apache.org/jira/browse/MENFORCER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289720#comment-17289720 ]

Krosheninnikov Artem commented on MENFORCER-376:
------------------------------------------------

[~jbennett2091], thanks for your input. I did current implementation as you described it in the first sentence. It indeed sounds counter-intuitive in a case with specific vendors. It's also good to get your reaction as PR was more or less reviewed could have reached master.

I'll rework the rule to support either excludes or includes, not both.

> Add support for excludes/includes in requireJavaVendor rule
> -----------------------------------------------------------
>
>                 Key: MENFORCER-376
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-376
>             Project: Maven Enforcer Plugin
>          Issue Type: Improvement
>          Components: Standard Rules
>    Affects Versions: 3.0.0-M3
>            Reporter: Krosheninnikov Artem
>            Priority: Major
>
> There was a suggestion here [1] to add includes/excludes support in requireJavaVendor rule. Right now it's not clear how it would work if you define the same vendor name in exclude and include lists but implementation can be more or less copied from BannedDependencies rule.
> [1] https://issues.apache.org/jira/browse/MENFORCER-338?focusedCommentId=17169044&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17169044



--
This message was sent by Atlassian Jira
(v8.3.4#803005)