[Commented] (MENFORCER-338) Along with JavaVersion, allow enforcement of the JavaVendor

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[Commented] (MENFORCER-338) Along with JavaVersion, allow enforcement of the JavaVendor

Olivier Lamy (Jira)

    [ https://issues.apache.org/jira/browse/MENFORCER-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169457#comment-17169457 ]

Jeffrey Bennett commented on MENFORCER-338:

As the original requester, my desire was to be able to steer teammates toward the "right" JDK.  In our organization, people throw around phrases like "we're switching from Oracle to OpenJDK", with developers naively then going and downloading "Oracle OpenJDK" and becoming frustrated when they find out its the wrong flavor (for us).  All that said, we'd be using the <include> flavor.


I can certainly see someone going the other route though.  For example, discovering some problem with Amazon's JDK (for them) and wanting to discourage the use of specific known issues.  The <exclude> could also be valid.

In both cases, it's there so the build fails-fast if a naive developer kicks off a build with a troubling JDK.


> Along with JavaVersion, allow enforcement of the JavaVendor
> -----------------------------------------------------------
>                 Key: MENFORCER-338
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-338
>             Project: Maven Enforcer Plugin
>          Issue Type: Improvement
>            Reporter: Jeffrey Bennett
>            Assignee: Robert Scholte
>            Priority: Major
>             Fix For: 3.0.0-M4
> It would be useful to be able to ensure that a particular vendor JDK is being used.  For example, I may need to confirm that we are using AdoptOpenJDK 1.8.0_232 and not Oracle JDK 1.8.0_232.   
> I would assume that you would define a set of enums for the vendors - e.g. (OracleJDK, AdoptOpenJDK, JavaOpenJDK, and maybe a few others) so that it would look something like this to insure that either Adopt or Amazon JDK vendor was used.
> EDIT: implemented as below, to be in line with RequireOs
> {code:xml}
> <requireJavaVendor>
>   <name>Oracle Corporation</name>
> </requireJavaVendor>
> {code}

This message was sent by Atlassian Jira