[Commented] (MEAR-171) Full customization of FileNameMapping is needed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Commented] (MEAR-171) Full customization of FileNameMapping is needed

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/MEAR-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165286#comment-16165286 ]

Hudson commented on MEAR-171:
-----------------------------

SUCCESS: Integrated in Jenkins build maven-plugins #9132 (See [https://builds.apache.org/job/maven-plugins/9132/])
[MEAR-171] Full customization of FileNameMapping is needed
 o Implemented full file name mapping by using
   maven-mapping shared component.
 o Made integration tests more reliable.
 o Changed all integration tests cause the default for the file name
   mapping is defined as:
   @{groupId}@-@{artifactId}@-@{version}@@{dashClassifier?}@.@{extension}@
 o Introduced a new parameter outputFileNameMapping which
   can be used to change the mapping based on the maven-mapping
   component. (khmarbaise: [http://svn.apache.org/viewvc/?view=rev&rev=1808287])
* (edit) maven-ear-plugin/pom.xml
* (edit) maven-ear-plugin/src/it/MEAR-243-skinny-wars-provided/verify.bsh
* (edit) maven-ear-plugin/src/it/non-skinny-wars/verify.bsh
* (edit) maven-ear-plugin/src/it/packaging-includes/verify.bsh
* (edit) maven-ear-plugin/src/it/settings.xml
* (edit) maven-ear-plugin/src/it/skinny-wars-filenamemapping-full/ear-module/pom.xml
* (edit) maven-ear-plugin/src/it/skinny-wars-filenamemapping-full/verify.bsh
* (edit) maven-ear-plugin/src/it/skinny-wars-filenamemapping-no-version/ear-module/pom.xml
* (edit) maven-ear-plugin/src/it/skinny-wars-javaee5/verify.bsh
* (edit) maven-ear-plugin/src/it/skinny-wars-timestamp/verify.bsh
* (edit) maven-ear-plugin/src/it/skinny-wars/verify.bsh
* (edit) maven-ear-plugin/src/it/transitive-excludes/invoker.properties
* (edit) maven-ear-plugin/src/it/transitive-excludes/verify.bsh
* (edit) maven-ear-plugin/src/main/java/org/apache/maven/plugins/ear/AbstractEarModule.java
* (edit) maven-ear-plugin/src/main/java/org/apache/maven/plugins/ear/AbstractEarMojo.java
* (edit) maven-ear-plugin/src/main/java/org/apache/maven/plugins/ear/EarExecutionContext.java
* (edit) maven-ear-plugin/src/main/java/org/apache/maven/plugins/ear/EarModuleFactory.java
* (edit) maven-ear-plugin/src/main/java/org/apache/maven/plugins/ear/EarMojo.java
* (delete) maven-ear-plugin/src/main/java/org/apache/maven/plugins/ear/output
* (edit) maven-ear-plugin/src/site/apt/index.apt.vm
* (edit) maven-ear-plugin/src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
* (delete) maven-ear-plugin/src/test/java/org/apache/maven/plugins/ear/output
* (edit) maven-ear-plugin/src/test/resources/projects/project-001/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-002/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-003/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-004/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-005/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-006/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-007/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-008/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-009/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-010/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-011/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-012/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-013/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-014/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-015/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-016/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-017/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-017/src/main/ear/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-019/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-020/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-021/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-023/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-024/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-025/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-027/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-028/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-029/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-030/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-031/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-032/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-033/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-033/expected-META-INF/jboss-app.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-034/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-036/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-036/pom.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-037/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-038/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-039/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-040/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-041/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-042/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-043/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-044/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-045/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-046/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-047/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-048/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-049/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-050/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-051/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-052/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-053/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-055/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-056/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-057/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-058/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-059/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-060/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-061/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-062/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-064/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-065/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-066/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-067/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-068/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-068/pom.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-069/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-070/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-071/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-072/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-073/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-074/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-075/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-076/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-077/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-078/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-078/pom.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-079/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-080/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-081/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-082/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-083/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-084/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-085/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-086/expected-META-INF/application.xml
* (edit) maven-ear-plugin/src/test/resources/projects/project-087/expected-META-INF/application.xml


> Full customization of FileNameMapping is needed
> -----------------------------------------------
>
>                 Key: MEAR-171
>                 URL: https://issues.apache.org/jira/browse/MEAR-171
>             Project: Maven Ear Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8
>            Reporter: Darryl L. Miles
>            Assignee: Karl Heinz Marbaise
>             Fix For: 3.0.0
>
>
> What is the logic with the seemingly non-standard conversion groupId by replacing '.' with '-' in the "full" mode ?  Surely this mode should have been called "full-with-groupId-rewrite".
> The purpose of this decision should have been documented in the code, someone needs to do so or make this format obsolete.
> Alternately the field should look at the maven-war-plugin and the ability to support mapping like:
> {noformat} @{groupId}@.@{artifactId}@@{dashClassifier?}@-@{version}@.@{extension}@ {noformat}
> Also the $\{project.finalName} and $\{project.name} would be useful (taken out of the dependency's own POM, not the EAR project).
> If this unusual replacement of groupId is required, then maybe @\{groupIdReplaceDots}@ can be provided.
> The problem is that the names used are IMPORTANT to know and automate because it maybe necessary to place them on the Class-Path in MANIFEST.MF files.
> This non-standard choice needs to be explained because it really is non-intuitive and there are no other mechanisms across the maven plugins to manage and rewrite Class-Path values in accordance with this convention.  There is on the other hand clear ways to configure a project and decide on the output file names on a project by project basis.  This is what should be the default, what the project itself decided it wanted to be called like $\{project.finalName}.
> The Maven documentation should include complete example of this "full" behaviour along with explanation of why it is useful to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)