[Commented] (MEAR-171) Full customization of FileNameMapping is needed

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[Commented] (MEAR-171) Full customization of FileNameMapping is needed

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/MEAR-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165278#comment-16165278 ]

Karl Heinz Marbaise commented on MEAR-171:

First part done in [r1808287|https://svn.apache.org/r1808287]

> Full customization of FileNameMapping is needed
> -----------------------------------------------
>                 Key: MEAR-171
>                 URL: https://issues.apache.org/jira/browse/MEAR-171
>             Project: Maven Ear Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8
>            Reporter: Darryl L. Miles
>            Assignee: Karl Heinz Marbaise
>             Fix For: 3.0.0
> What is the logic with the seemingly non-standard conversion groupId by replacing '.' with '-' in the "full" mode ?  Surely this mode should have been called "full-with-groupId-rewrite".
> The purpose of this decision should have been documented in the code, someone needs to do so or make this format obsolete.
> Alternately the field should look at the maven-war-plugin and the ability to support mapping like:
> {noformat} @{groupId}@.@{artifactId}@@{dashClassifier?}@-@{version}@.@{extension}@ {noformat}
> Also the $\{project.finalName} and $\{project.name} would be useful (taken out of the dependency's own POM, not the EAR project).
> If this unusual replacement of groupId is required, then maybe @\{groupIdReplaceDots}@ can be provided.
> The problem is that the names used are IMPORTANT to know and automate because it maybe necessary to place them on the Class-Path in MANIFEST.MF files.
> This non-standard choice needs to be explained because it really is non-intuitive and there are no other mechanisms across the maven plugins to manage and rewrite Class-Path values in accordance with this convention.  There is on the other hand clear ways to configure a project and decide on the output file names on a project by project basis.  This is what should be the default, what the project itself decided it wanted to be called like $\{project.finalName}.
> The Maven documentation should include complete example of this "full" behaviour along with explanation of why it is useful to the user.

This message was sent by Atlassian JIRA