[Commented] (MDEPLOY-131) use default repository when no url specified

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[Commented] (MDEPLOY-131) use default repository when no url specified

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931911#comment-15931911 ]

Richard Sand commented on MDEPLOY-131:

Hi Karl - I could make a multi-module project, but why when there is a very simple capability that can let me avoid that and have 1 POM build everything I need? If you take a look at the patch its hardly anything at all and adds a capability that is useful and that others have requested.

Regarding the slf4j - there are situations where my customers want a single jar that can be dropped into their application without a single other dependency, which is really the use case for shaded jars in the first place. And they are not familiar with slf4j, so I provide a shaded jar that has slf4j and for example slf4j-jcl or slf4j-jul, so that they can continue to run with whatever log framework they're already using without needing any other jar than the single that our product provides.

> use default repository when no url specified
> --------------------------------------------
>                 Key: MDEPLOY-131
>                 URL: https://issues.apache.org/jira/browse/MDEPLOY-131
>             Project: Maven Deploy Plugin
>          Issue Type: Improvement
>          Components: deploy:deploy-file
>            Reporter: raymond domingo
>              Labels: contributers-welcome
>         Attachments: DeployFileMojo.java, maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff
> When using the deploy goal there is no need to specify the url of the repository.
> When using deploy-file you DO need to specify the url. This is a problem, because during development I like to deploy to snapshot repository and when releasing i deploy to release repository and I can't add this logic to the pom.
> Thas is why I like the url paramter to become optional (backwards compatible) and add default behaviour when it is null. It should just like the deploy plugin use the default repository. Snapshot for snapshots and release for none snapshot versions.
> I added a patch file fixing this.
> I also added complete source of patched Mojo

This message was sent by Atlassian JIRA