[Commented] (MANTRUN-221) Fails to pass maven properties set in user properties only

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Commented] (MANTRUN-221) Fails to pass maven properties set in user properties only

M.P. Korstanje (Jira)

    [ https://issues.apache.org/jira/browse/MANTRUN-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970843#comment-16970843 ]

Alex Szczuczko commented on MANTRUN-221:
----------------------------------------

Pull Request: https://github.com/apache/maven-antrun-plugin/pull/1

> Fails to pass maven properties set in user properties only
> ----------------------------------------------------------
>
>                 Key: MANTRUN-221
>                 URL: https://issues.apache.org/jira/browse/MANTRUN-221
>             Project: Maven Antrun Plugin
>          Issue Type: Bug
>    Affects Versions: 1.8
>            Reporter: Alex Szczuczko
>            Priority: Major
>         Attachments: mwe.zip
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> A user of mine [reported a problem|https://github.com/ASzc/jsonpath-maven-plugin/issues/3] between jsonpath-maven-plugin:set-properties and maven-antrun-plugin:run. My analysis points to a bug in maven-antrun-plugin, introduced in version 1.8 by MANTRUN-178.
> MANTRUN-178 incorrectly assumes in AntRunMojo#copyProperties() that all properties will be present in mavenProject.getProperties(), and so fails to copy properties set at runtime in session.getUserProperties().
> I've attached a MWE, showing maven-help-plugin:evaluate seeing the property set by jsonpath-maven-plugin:set-properties, and maven-antrun-plugin:run failing to see the same property.
> I intend to file a PR to fix this shortly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)