[Comment Edited] (MRESOURCES-273) Filtering of Maven properties with long names is not working after transition from 2.6 to 3.2.0

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Comment Edited] (MRESOURCES-273) Filtering of Maven properties with long names is not working after transition from 2.6 to 3.2.0

Joshua (Jira)

    [ https://issues.apache.org/jira/browse/MRESOURCES-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264789#comment-17264789 ]

Elias Balasis edited comment on MRESOURCES-273 at 1/14/21, 11:19 AM:
---------------------------------------------------------------------

Clone Github repository at [https://github.com/eliasbalasis/maven-resources-plugin-bug-273]

I have verified this under Windows 10 and Maven 3.6.3

Set the following environment variables
CLOUD_AZURE_AKS_KUBERNETES_NODE_LABEL_AGENTPOOL_VALUE_TEST_XXXXXXXXXXX_NODE_IMPL_PRODUCT_SEGMENT_PROCESSOR=something1
CLOUD_AZURE_AKS_KUBERNETES_NODE_LABEL_AGENTPOOL_VALUE_QA_XXXXXXXXXXX_NODE_IMPL_PRODUCT_SEGMENT_PROCESSOR=something2
CLOUD_AZURE_AKS_KUBERNETES_NODE_LABEL_AGENTPOOL_VALUE_PRODUCTION_XXXXXXXXXXX_NODE_IMPL_PRODUCT_SEGMENT_PROCESSOR=something3
ENVIRONMENT_VARIABLE_WITH_SMALLER_LENGTH=somethingelse

Run "{{mvn package}}"
Notice that the generated files under "{{target/classes}}" are not filtered.

Change the {{version.maven-resources-plugin}} variable in {{pom.xml}} from {{3.2.0}} to {{2.6}} and run "{{mvn package}}" again.
Notice that this time the generated files under "{{target/classes}}" are now properly filtered and the Maven variable references are properly replaced with the respective environment variable values.



was (Author: eliasbalasis):
Clone Github repository at [https://github.com/eliasbalasis/maven-resources-plugin-bug-273]

I have verified this under Windows 10 and Maven 3.6.3

Set the following environment variables
CLOUD_AZURE_AKS_KUBERNETES_NODE_LABEL_AGENTPOOL_VALUE_TEST_XXXXXXXXXXX_NODE_IMPL_PRODUCT_SEGMENT_PROCESSOR=something1
CLOUD_AZURE_AKS_KUBERNETES_NODE_LABEL_AGENTPOOL_VALUE_QA_XXXXXXXXXXX_NODE_IMPL_PRODUCT_SEGMENT_PROCESSOR=something2
CLOUD_AZURE_AKS_KUBERNETES_NODE_LABEL_AGENTPOOL_VALUE_PRODUCTION_XXXXXXXXXXX_NODE_IMPL_PRODUCT_SEGMENT_PROCESSOR=something3
ENVIRONMENT_VARIABLE_WITH_SMALLER_LENGTH=somethingelse

Run "mvn package"
Notice that the generated files under {{target/classes}} are not filtered.

Change the {{version.maven-resources-plugin}} variable in {{pom.xml}} from {{3.2.0}} to {{2.6}} and run {{mvn package}} again.
Notice that this time the generated files under {{target/classes}} are now properly filtered and the Maven variable references are properly replaced with the respective environment variable values.


> Filtering of Maven properties with long names is not working after transition from 2.6 to 3.2.0
> -----------------------------------------------------------------------------------------------
>
>                 Key: MRESOURCES-273
>                 URL: https://issues.apache.org/jira/browse/MRESOURCES-273
>             Project: Maven Resources Plugin
>          Issue Type: Bug
>          Components: filtering
>    Affects Versions: 3.2.0
>            Reporter: Elias Balasis
>            Priority: Critical
>             Fix For: waiting-for-feedback
>
>
> In my team, part of a large global organization, we have upgraded from 2.6 to 3.2.0
> but only to discover that 3.2.0 is not filtering Maven properties with long names anymore.
> The particular Maven property which wasn't filtered is 148 characters long.
> This has never been a problem with 2.6 though.
> It is implied that a breaking change has been made after 2.6 which now prevents us from upgrading.
> We are temporarily reverting to 2.6 but only temporarily.
> Equally, the cost of reducing the length of the associated Maven properties is not affordable and we will not apply such a workaround.
> Please revert the broken functionality.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)