[Comment Edited] (MRELEASE-897) support multiple release versions

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Comment Edited] (MRELEASE-897) support multiple release versions

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/MRELEASE-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646785#comment-16646785 ]

Carsten Klein edited comment on MRELEASE-897 at 10/11/18 5:17 PM:
------------------------------------------------------------------

I am currently looking into this feature as I need it both for my personal projects and for work.

Looking at the code, I have a few questions:
 # I need to make changes to the ReleaseDescriptor API. Currently, the release descriptor is generated from some modello model.
 # Similar so for the ReleaseStageVersions class, which is also simple enough to implement it directly.

Do you have any objections in removing this extra dependency (modello code generation for two classes) and implement both directly?

Must the name ModelloReleaseDescriptor be preserved or can it be renamed to just DefaultReleaseDescriptor?

There are also two helper classes, namely ReleaseDescriptorXpp3Reader and ReleaseDescriptorXpp3Writer, which, as far as I can tell,

are never used by the maven release plugin. Can these two be removed?

 


was (Author: silkentrance):
I am currently looking into this feature as I need it both for my personal projects and for work.

Looking at the code, I have a few questions:
 # I need to make changes to the ReleaseDescriptor API. Currently, the release descriptor is generated from some modello model.
 # Similar so for the ReleaseStageVersions class, which is also simple enough to implement it directly.

Do you have and objections in removing this extra dependency (modello code generation for two classes) and implement both directly?

Must the name ModelloReleaseDescriptor be preserved or can it be renamed to just DefaultReleaseDescriptor?

There are also two helper classes, namely ReleaseDescriptorXpp3Reader and ReleaseDescriptorXpp3Writer, which, as far as I can tell,

are never used by the maven release plugin. Can these two be removed?

 

> support multiple release versions
> ---------------------------------
>
>                 Key: MRELEASE-897
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-897
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>            Priority: Major
>
> In some project multiple versions are used (tomee release = tomee + openejb releases for instance). It is not always possible to split the project in sub projects and then it is not possible to use maven release plugin. Idea would be to support a whitelist of artifacts (a list of patterns would be great).
> {code}
> <releaseVersions>
>   <releaseVersion>org.superbiz.component:*:1.0.1</releaseVersion>
>   <releaseVersion>org.superbiz.component:*:4.5.8</releaseVersion>
> </releaseVersions>
> {code}
> For instance or even:
> {code}
> <releaseVersions>
>   <releaseVersion>org.superbiz.component:*:@major.@minor.@patch</releaseVersion>
>   <releaseVersion>org.superbiz.component:*:(@major + 3).@minor.@patch</releaseVersion>
> </releaseVersions>
> {code}
> to avoid to change it for each release.
> This of course would imply the CLI to ask for the multiple versions and not only one even when autoSubModules is set to true (it would just group by versions)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)