[Comment Edited] (MJAVADOC-533) <link> entries that point to a resource that requires an Accept header may be ignored

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Comment Edited] (MJAVADOC-533) <link> entries that point to a resource that requires an Accept header may be ignored

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/MJAVADOC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575265#comment-16575265 ]

Andy Wilkinson edited comment on MJAVADOC-533 at 8/9/18 6:41 PM:
-----------------------------------------------------------------

I don't really know the reasoning for Cloudflare's rule behaving the way it does and why it treats no {{Accept}} header differently to {{Accept \*/\*}}. It, as you say, is the default after all. Given what {{JavadocUtil}} is doing, accepting anything seems reasonable as it's only really interested in redirects and will accept (and ignore) any body. It wouldn't address this issue, but given that behaviour perhaps a {{HEAD}} request could be used to save some bandwidth?

In case you're doing any further testing, our sysadmin's in the process of tweaking the configuration so you may soon get a 200 back from docs.spring.io even without the {{Accept}} header.

 

 


was (Author: awilkinson):
I don't really know the reasoning for Cloudflare's rule behaving the way it does and why it treats no {{Accept}} header differently to {{Accept */*}}. It, as you say, is the default after all. Given what {{JavadocUtil}} is doing, accepting anything seems reasonable as it's only really interested in redirects and will accept (and ignore) any body. It wouldn't address this issue, but given that behaviour perhaps a {{HEAD}} request could be used to save some bandwidth?

In case you're doing any further testing, our sysadmin's in the process of tweaking the configuration so you may soon get a 200 back from docs.spring.io even without the {{Accept}} header.

 

 

> <link> entries that point to a resource that requires an Accept header may be ignored
> -------------------------------------------------------------------------------------
>
>                 Key: MJAVADOC-533
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-533
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>    Affects Versions: 3.0.1
>            Reporter: Andy Wilkinson
>            Priority: Minor
>
> This is a regression caused by the changes made to fix MJAVADOC-427.
> The HTTP client configuration that's used to get the redirect URLs does not include an {{Accept}} header in the requests that it makes. This can result in a 403 response for some javadoc, such as Spring Framework's which is fronted by Cloudflare. The lack of {{Accept}} header will sometimes cause Cloudflare to respond with a 403 containing a Captcha.
> I'm a member of the Spring Framework team and have asked our sysadmin to look at tweaking Cloudflare's rules, but I thought it worth reporting the problem here as others may be affected and may not be in a position to change the server's configuration.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)