[Closed] (MENFORCER-194) Rule RequireSameVersions: dependency artifacts are not checked

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Closed] (MENFORCER-194) Rule RequireSameVersions: dependency artifacts are not checked

Robert Scholte (Jira)

     [ https://issues.apache.org/jira/browse/MENFORCER-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte closed MENFORCER-194.
------------------------------------
      Assignee: Robert Scholte
    Resolution: Cannot Reproduce

Added IT in [4ff8bf4de1893b3de8166c48c57ae5363ba11eda|https://gitbox.apache.org/repos/asf?p=maven-enforcer.git;a=commit;h=4ff8bf4de1893b3de8166c48c57ae5363ba11eda] to confirm rule works as expected

> Rule RequireSameVersions: dependency artifacts are not checked
> --------------------------------------------------------------
>
>                 Key: MENFORCER-194
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-194
>             Project: Maven Enforcer Plugin
>          Issue Type: Bug
>          Components: Standard Rules
>    Affects Versions: 1.3.1
>            Reporter: Rod Woo
>            Assignee: Robert Scholte
>            Priority: Major
>              Labels: up-for-grabs
>         Attachments: RequireSameVersions_setDependencies.patch
>
>
> In RequireSameVersions.java you must prefer the method project.getDependencyArtifacts() to project.getArtifacts().
> Testcase and patch are attached.
> Furthermore, the official documentation of the rule should make clear that transitive dependencies are not considered. This will make the rule for many users meaningless.
> Furthermore, the official documentation of the rule should make clear that the test coverage of the rule implementation is small.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)