Bug SCM-244

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug SCM-244

Ryan Daum-2
http://jira.codehaus.org/browse/SCM-244

This bug seems to still be in the trunk despite the JIRA issue being marked closed.

To summarize, distribution SCMs like Mercurial or Bazaar or Darcs, etc. will often have almost-instantaneous checkin times.  So the check in ChangeLogCommandTckTest which expects a second to have passed since the commit succeeded is flawed.  Either perform a (minimum) 1 second wait, or do not perform the time check.  I submitted a patch to perform the one second check, and it seems to have gone ignored?

Ryan

--
Ryan Daum
[hidden email]
Senior Developer, Toronto
647.724.5232 x 2073
Reply | Threaded
Open this post in threaded view
|

Re: Bug SCM-244

Ryan Daum-2
I take that back, sorry, on further inspection I see that the relevant classes have indeed been changed.

My bad, again sorry

Ryan

On 4/4/07, Ryan Daum <[hidden email]> wrote:
<a href="http://jira.codehaus.org/browse/SCM-244" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> http://jira.codehaus.org/browse/SCM-244

This bug seems to still be in the trunk despite the JIRA issue being marked closed.

To summarize, distribution SCMs like Mercurial or Bazaar or Darcs, etc. will often have almost-instantaneous checkin times.  So the check in ChangeLogCommandTckTest which expects a second to have passed since the commit succeeded is flawed.  Either perform a (minimum) 1 second wait, or do not perform the time check.  I submitted a patch to perform the one second check, and it seems to have gone ignored?

Ryan

--
Ryan Daum
[hidden email]
Senior Developer, Toronto
647.724.5232 x 2073



--
Ryan Daum
[hidden email]
Senior Developer, Toronto
647.724.5232 x 2073