Add permissions to close Pull Requests in ASF projects at GitHub

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Add permissions to close Pull Requests in ASF projects at GitHub

Tibor Digana
Do you have permissions to close pull requests in our ASF Maven projects?
Me either!
I would like to close completed PRs which leak in the list at GitHub and
the particular person does not respond to my request.

T
Reply | Threaded
Open this post in threaded view
|

Re: Add permissions to close Pull Requests in ASF projects at GitHub

Hervé BOUTEMY
Tibor,

With GitBox, Maven developpers can have the permission: this is one of the key
feature we expected from GitBox migration

See "Link GitHub and ASF accounts (required to push to GitHub)" link on
https://gitbox.apache.org/

You're not yet linked, you should follow the instructions and you'll see.

Regards,

Hervé

Le dimanche 18 mars 2018, 19:50:45 CET Tibor Digana a écrit :
> Do you have permissions to close pull requests in our ASF Maven projects?
> Me either!
> I would like to close completed PRs which leak in the list at GitHub and
> the particular person does not respond to my request.
>
> T



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Add permissions to close Pull Requests in ASF projects at GitHub

michaelo
In reply to this post by Tibor Digana
Am 2018-03-18 um 21:26 schrieb Tibor Digana:
> I always do it with interactive 'git rebase' in IntelliJ IDEA.
> If there is a merge conflict, the contributor creates a new PR which has
> happened maybe only once.
> The most of the time the repo could be successfully rebased on master HEAD.

That's the right approach. I just wanted to emphasize *not* to rely on
GitHub's default behavior. I know that this can be changed in GitLab,
maybe infra can change this for us on GitHub too? Less hassle for everyone.


Michael

> On Sun, Mar 18, 2018 at 8:41 PM, Michael Osipov <[hidden email]> wrote:
>
>> Am 2018-03-18 um 20:28 schrieb Karl Heinz Marbaise:
>>
>>> Hi Tibor,
>>>
>>> On 18/03/18 19:50, Tibor Digana wrote:
>>>
>>>> Do you have permissions to close pull requests in our ASF Maven projects?
>>>>
>>>
>>> Are you allowed to do merge a pull request via GitHub ?
>>>
>>
>> Please don't do that. GitHub will -- by default -- do a no-ff merge with
>> ugly and useless merge commits. You have either to explicitly say ff merge
>> or do via shell.
>>
>> Michael
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]